reta commented on a change in pull request #904:
URL: https://github.com/apache/cxf/pull/904#discussion_r805386127
##########
File path:
rt/frontend/simple/src/main/java/org/apache/cxf/frontend/WSDLGetUtils.java
##########
@@ -566,9 +566,6 @@ private void processSchemaReference(SchemaReference
schemaReference,
doneSchemas.put(decodedStart, schemaReference);
doneSchemas.put(schemaReference.getReferencedSchema().getDocumentBaseURI(),
schemaReference);
- if (!doneSchemas.containsKey(decodedOrigLocation)) {
Review comment:
@dkulp could you please take a look? we have interesting case of
conflicting `decodedStart` / `decodedOrigLocation` pairs:
```
decodedStart = common.xsd
decodedOrigLocation = ../common.xsd
```
```
decodedStart = d/common.xsd
decodedOrigLocation = common.xsd
```
It seems to make sense to use either one of those or, alternatively, detect
the conflict and remove the entry from `doneSchemas` (using
`getSchemaLocationURI` as differentiator).
WDYT? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
