reta commented on code in PR #954:
URL: https://github.com/apache/cxf/pull/954#discussion_r895181297
##########
rt/features/clustering/src/main/java/org/apache/cxf/clustering/RetryStrategy.java:
##########
@@ -42,7 +42,11 @@ public List<Endpoint> getAlternateEndpoints(Exchange
exchange) {
}
protected <T> T getNextAlternate(List<T> alternates) {
- return stillTheSameAddress() ? alternates.get(0) :
alternates.remove(0);
+ // is the amount of retries for the first alternate already exceeded?
+ if (!stillTheSameAddress()) {
+ alternates.remove(0);
+ }
+ return alternates.isEmpty() ? null : alternates.get(0);
Review Comment:
@kwin for this particular issue (have not looked into CXF-8288) we should be
able to keep SPI unchanged by documenting `getNextAlternate` could return
`null` and making sure `AbstractStaticFailoverStrategy` could deal with `null`
in `selectAlternateXxx` methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
