JohnMTu commented on PR #1150:
URL: https://github.com/apache/cxf/pull/1150#issuecomment-1484695510

   @reta : This is ticket i just made 
https://issues.apache.org/jira/browse/CXF-8831
   
   Having option to provide own instance of MaskSensitiveHelper subclass would 
be also fine for me. 
   Perhaps it can be even refactored to interface. 
   
   Only not so nice thing might be, that method setSensitiveElementNames is 
invoked from AbstractLoggingInterceptor#setSensitiveElementNames and 
LoggingFeature and LoggingFeature.Portable.
   Similar for setSensitiveProtocolHeaderNames.
   In case of our implementation such method would have no use. But for 
backward compatibility we would need to keep them.
   
   Do you want to do stuff yourself, or should i provide it? 
   If i should do it, do you prefer to keep MaskSensitiveHelper a class or 
should be interface refactored out of it?
   
   thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to