LeoWoerteler commented on PR #1381: URL: https://github.com/apache/cxf/pull/1381#issuecomment-1676428964
> Could you elaborate more on that please? `WebClient::close` could be called when client is not used anymore. It is indeed not `AutoCloseable` (I think the initial version predates JDK 1.7 when this interface was introduced) but it should I think. It could be called, it it practically didn't have to be, so lots of existing code doesn't. Until CXF 3.5 it was evidently enough to close the `Response` to avoid leaking resources, and there are plenty of sources online that claim that. Now in 4.0 the same pattern is suddenly leaky. That is at the very least a giant foot-gun for anyone upgrading CXF on older code bases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
