Taher-Ghaleb commented on PR #1395: URL: https://github.com/apache/cxf/pull/1395#issuecomment-1687276003
I checked "assertTrue.*equals" but I found out that in almost all cases, the equality-checking methods are specialized (e.g., `boolean equals`, `boolean equalsTime`, etc.) and hence refactoring them may not produce the expected results. I searched for "assertTrue.*!equals", which could be refactored using _assertNotEquals_ as well, but didn't find any cases. For _assertThrows_, I actually found many refactoring opportunities in different test files, but I can do it in a separate pull request, to make the scope of this one for equality assertions, as you suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
