Silwing commented on code in PR #1426:
URL: https://github.com/apache/cxf/pull/1426#discussion_r1318853100
##########
rt/features/logging/src/test/java/org/apache/cxf/ext/logging/LogEventSenderMock.java:
##########
@@ -18,20 +18,27 @@
*/
package org.apache.cxf.ext.logging;
+import java.util.ArrayList;
+import java.util.List;
+
import org.apache.cxf.ext.logging.event.LogEvent;
import org.apache.cxf.ext.logging.event.LogEventSender;
public class LogEventSenderMock implements LogEventSender {
- private LogEvent logEvent;
+ private List<LogEvent> logEvents = new ArrayList<>();
Review Comment:
If we don't capture multiple events the test will only show the missing
payload issue, not the multiple events issue. To ensure regression prevention
in the unit test I kept the list to capture the requirement of only sending a
single event.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
