reta commented on code in PR #1454:
URL: https://github.com/apache/cxf/pull/1454#discussion_r1342160643
##########
rt/transports/http-jetty/src/main/java/org/apache/cxf/transport/http_jetty/JettyHTTPServerEngine.java:
##########
@@ -697,7 +697,8 @@ AbstractConnector
createConnectorJetty(SslContextFactory.Server sslcf, String ho
final SslConnectionFactory scf = new
SslConnectionFactory(sslcf, alpn.getProtocol());
connectionFactories.add(scf);
Review Comment:
> I would be happy to refactor so that the first connector (which is
http/1.1) is added after the isHttp2Enabled block, which would remove the need
to explicitly add http2 as the first item in the list.
I think that would make sense, thank you. It also is aligned with Jetty
examples [1]
[1]
https://github.com/eclipse/jetty.project/blob/jetty-9.4.14.v20181114/examples/embedded/src/main/java/org/eclipse/jetty/embedded/Http2Server.java
##########
rt/transports/http-jetty/src/main/java/org/apache/cxf/transport/http_jetty/JettyHTTPServerEngine.java:
##########
@@ -697,7 +697,8 @@ AbstractConnector
createConnectorJetty(SslContextFactory.Server sslcf, String ho
final SslConnectionFactory scf = new
SslConnectionFactory(sslcf, alpn.getProtocol());
connectionFactories.add(scf);
Review Comment:
> I would be happy to refactor so that the first connector (which is
http/1.1) is added after the isHttp2Enabled block, which would remove the need
to explicitly add http2 as the first item in the list.
I think that would make sense, thank you. It also will be aligned with Jetty
examples [1]
[1]
https://github.com/eclipse/jetty.project/blob/jetty-9.4.14.v20181114/examples/embedded/src/main/java/org/eclipse/jetty/embedded/Http2Server.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
