reta commented on PR #1472: URL: https://github.com/apache/cxf/pull/1472#issuecomment-1772934037
> Why would the out interceptor chain be called when there isn't a message? That seems wrong. This just "fakes" a message which doesn't seem right. My gut feeling is that this would also break the JSX-WS TCK if this ends up calling the JAX-WS handlers. Thanks @dkulp! There is `out` message, always, but not `in` message. And we call only `OneWayInterceptor` in this case, as I mentioned the change is non-breaking - none of the existing interceptors in the chain will be called unless opted in (by implementing `OneWayInterceptor`). > OpenTelemetry likely should have an interceptor at the end of the in chain which checks the operation and if it's a one way, close whatever it needs to close at that point. It could be done as well, the issue is that it someone has to know that a) message is one way, it should be checked b) the `in` interceptors won't be called This is very easy to forget and catch, with `OneWayInterceptor` at least the handling could be formalized and generalized. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
