reta commented on code in PR #1504:
URL: https://github.com/apache/cxf/pull/1504#discussion_r1380910902


##########
core/src/test/java/org/apache/cxf/helpers/FileUtilsTest.java:
##########
@@ -77,6 +78,8 @@ public void testGetFiles() throws URISyntaxException {
 
         List<File> foundFiles2 = FileUtils.getFiles(directory, ".*\\.class$");
 
+        Collections.sort(foundFiles);

Review Comment:
   @prathyushreddylpr thank you for the fix, although I've never seen this test 
failing, the File System API indeed does not guarantee an order. There is an 
issue with this patch, the `Collections.sort` requires the collection to be 
modifiable which we cannot guarantee.
   
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to