prathyushreddylpr commented on PR #1516: URL: https://github.com/apache/cxf/pull/1516#issuecomment-1807180858
> > > @prathyushreddylpr I don't see any comparison logic in `org.apache.cxf.javascript.types.SerializationTest.testDeserialization` that relies on order of the properties. where this hypothesis is coming from? > > > > > > In the 'testDeserialization' there is a call to 'rhinoCallInContext' which internally calls deserializeTestBean3_1(serialized string) here: ' > > https://github.com/apache/cxf/blob/74069a140737603a0a59435de308401c4351a80b/rt/javascript/javascript-tests/src > > ' and the actual comparison is happening here. > > But it compares deserialized form of each attribute, the order does not matter here Yes but when the class is serialized to a string, the attributes does not follow any particular and when the string is compared with certain value it is causing the issue. For example, below are two serialized strings for two different runs: First: <img width="306" alt="image" src="https://github.com/apache/cxf/assets/112648268/a845f769-680b-4bf4-8e8e-6366e65710fa";> Second: <img width="444" alt="image" src="https://github.com/apache/cxf/assets/112648268/8c2df9f9-ccba-4111-aff1-c644dd6af226";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
