gchauvet commented on code in PR #1674:
URL: https://github.com/apache/cxf/pull/1674#discussion_r1479372350
##########
core/src/main/java/org/apache/cxf/attachment/AttachmentSerializer.java:
##########
@@ -327,7 +327,7 @@ public void writeAttachments() throws IOException {
StringWriter writer = new StringWriter();
writer.write("\r\n--");
writer.write(bodyBoundary);
- writer.write("--");
+ writer.write("--\r\n");
Review Comment:
hello @reta,
Unless I've misinterpreted the quote below, aren't we supposed to have a
CRLF?
> Note that the encapsulation boundary must occur at the beginning of a
line, i.e., following a CRLF, and that that initial CRLF is considered to be
part of the encapsulation boundary rather than part of the preceding part. The
boundary must be followed immediately either by another CRLF and the header
fields for the next part, or by two CRLFs, in which case there are no header
fields for the next part (and it is therefore assumed to be of Content-Type
text/plain).
Or the webservice I'm calling follows RFC 2046
(https://www.rfc-editor.org/rfc/rfc2046#page-44):
```
multipart-body := [preamble CRLF]
dash-boundary transport-padding CRLF
body-part *encapsulation
close-delimiter transport-padding
[CRLF epilogue]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
