mcarbonneaux commented on code in PR #2411:
URL: https://github.com/apache/cxf/pull/2411#discussion_r2107629153
##########
rt/transports/http/src/main/java/org/apache/cxf/transport/http/HttpClientHTTPConduit.java:
##########
@@ -425,6 +425,9 @@ protected void setupConnection(Message message, Address
address, HTTPClientPolic
}
}
String verc =
(String)message.getContextualProperty(FORCE_HTTP_VERSION);
+ if (verc == null && "http".equals(uri.getScheme())) {
Review Comment:
httpclient leave you the posibility to choose... and cxf conduit can
choose... cxf httpclient conduit are not oblige to follow the default of
httpclient... if in majority of the time in cxf use case with http (more than
90% i think! in fact only java http backend using openjdk server http/2 work...
and only suffisant recent version of the openjdk...) is not working fine...
because h2c are not realy implemented in fact on backend...
using http/2 by default is ok with tls/https.... but with http (h2c)... is
not working fine at all... and i think while never work because majority of the
implementer don't whan to implement...or badly implement it...
##########
rt/transports/http/src/main/java/org/apache/cxf/transport/http/HttpClientHTTPConduit.java:
##########
@@ -425,6 +425,9 @@ protected void setupConnection(Message message, Address
address, HTTPClientPolic
}
}
String verc =
(String)message.getContextualProperty(FORCE_HTTP_VERSION);
+ if (verc == null && "http".equals(uri.getScheme())) {
Review Comment:
httpclient leave you the posibility to choose... and cxf conduit can
choose... cxf httpclient conduit are not oblige to follow the default of
httpclient... if in majority of the time in cxf use case with http (more than
90% i think! in fact only java http backend using openjdk server http/2 work...
and only suffisant recent version of the openjdk...) is not working fine...
because h2c are not realy implemented in fact on backend...
using http/2 by default is ok with tls/https.... but with http (h2c)... is
not working fine at all... and i think while never work because majority of the
implementer don't whant to implement...or badly implement it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
