ppalaga commented on code in PR #2557:
URL: https://github.com/apache/cxf/pull/2557#discussion_r2288594610


##########
parent/pom.xml:
##########
@@ -585,7 +586,19 @@
                         <dependency>
                             <groupId>org.apache.groovy</groupId>
                             <artifactId>groovy</artifactId>
-                            <version>4.0.27</version>
+                            <version>${cxf.groovy.version}</version>
+                        </dependency>
+                    </dependencies>
+                </plugin>
+                <plugin>
+                    <groupId>org.codehaus.gmaven</groupId>

Review Comment:
   Ouch, I just found out, how many changes the suffix file is receiving 
https://github.com/publicsuffix/list/commits/main/public_suffix_list.dat
   It is nearly every day.
   I am afraid, the approach proposed in this PR would not be sustainable.
   
   It would actually be enough to update the list shortly before releasing CXF. 
@ffang I wonder whether there is any release automation in place for CXF? Is 
there a CI job or a script? If so, the suffix list update could be added there. 
 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to