github-advanced-security[bot] commented on code in PR #2698: URL: https://github.com/apache/cxf/pull/2698#discussion_r2508346747
########## core/src/main/java/org/apache/cxf/attachment/AttachmentDeserializerUtil.java: ########## @@ -0,0 +1,175 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.cxf.attachment; + +import java.io.IOException; +import java.io.InputStream; +import java.io.PushbackInputStream; +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.TreeMap; +import java.util.logging.Logger; + +import org.apache.cxf.common.logging.LogUtils; + +final class AttachmentDeserializerUtil { + /* Keep the log under AttachmentDeserializer */ + private static final Logger LOG = LogUtils.getL7dLogger(AttachmentDeserializer.class); + + private AttachmentDeserializerUtil() { + } + + /** + * Move the read pointer to the begining of the first part read till the end + * of first boundary + * + * @param pushbackInStream + * @param boundary + * @throws IOException + */ + static boolean readTillFirstBoundary(PushbackInputStream pushbackInStream, + byte[] boundary) throws IOException { + + // work around a bug in PushBackInputStream where the buffer isn't + // initialized + // and available always returns 0. + int value = pushbackInStream.read(); + pushbackInStream.unread(value); + while (value != -1) { + value = pushbackInStream.read(); + if ((byte) value == boundary[0]) { Review Comment: ## User-controlled data in numeric cast This cast to a narrower type depends on a [user-provided value](1), potentially causing truncation. This cast to a narrower type depends on a [user-provided value](2), potentially causing truncation. [Show more details](https://github.com/apache/cxf/security/code-scanning/2209) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
