gnodet commented on PR #1685: URL: https://github.com/apache/cxf/pull/1685#issuecomment-4037079167
## Review & Fixes I've reviewed this PR and it looks good overall. Clean, well-structured change that correctly adds support for the MTOM Serialization Policy Assertion 1.1 namespace (`http://www.w3.org/2007/08/soap12-mtom-policy` / `MTOM` element) alongside the existing 1.0 namespace (`http://schemas.xmlsoap.org/ws/2004/09/policy/optimizedmimeserialization` / `OptimizedMimeSerialization` element). ### What I did 1. **Rebased onto current `main`** — The branch was based on `4.0.4-SNAPSHOT` (from 2024) and couldn't compile. Rebase was clean, no conflicts. 2. **Fixed minor code style issue** — Removed an extra blank line in `MetadataConstants.java` between the constant declarations and the private constructor. 3. **Verified**: All 133 tests in `rt/ws/policy` pass. Checkstyle is clean. ### Review notes The production code changes are clean and well-designed: - `MetadataConstants` — new `MTOM11_ASSERTION_QNAME` constant with correct W3C namespace - `MTOMAssertionBuilder` — correctly handles both QNames in `KNOWN_ELEMENTS` and `build()` - `MTOMPolicyInterceptor` — good refactoring to extract `assertAssertion()` as a reusable static method - `MTOMPolicyInterceptorProvider` — correctly registers both assertion types - Test coverage includes both required and optional variants of the MTOM 1.1 policy, mirroring the existing 1.0 tests - The new policy XML files correctly use the W3C MTOM 1.1 namespace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
