gnodet commented on PR #1483: URL: https://github.com/apache/cxf/pull/1483#issuecomment-4038692781
Hi @reta, I've pushed a commit addressing your review feedback: - **Removed** the `URI.getHost()` shortcut in `Rfc3986UriValidator` — you were right that Java's `URI.getHost()` is not RFC-3986 compliant, so it can't be trusted here. - **Simplified** `HttpUtils.isHttpScheme()` to use `equalsIgnoreCase()` with two string constants instead of a `HashSet`, as you suggested. Also, while investigating the flaky `NettyServerTest.testGetWsdl` from #1517, we found the root cause: `ServiceWSDLBuilder` uses a `HashMap` for namespace-to-prefix mapping, causing non-deterministic WSDL output. That's been fixed separately in #2944. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
