gnodet commented on PR #2967:
URL: https://github.com/apache/cxf/pull/2967#issuecomment-4055154581
Closing this PR — the diagnosis was incorrect.
The OAuth2 test failures (32/89 in `AuthorizationGrantTest`, 24/32 in
`PublicClientTest`) are **not** caused by servers failing to start.
Investigation showed:
1. If a server failed to start, `ServerLauncher.launchServer()` would
trigger `assertTrue("server failed to launch", ok)` and **all** tests would
fail (89/89), not just 32/89.
2. The 32/89 pattern is actually **8 specific tests failing × 4 attempts**
(1 original + 3 surefire retries). The servers start successfully.
3. The failures are runtime test failures specific to the CI environment —
all 65 tests pass locally.
Using `Assume.assumeTrue` here wouldn't help (servers do start, so it always
passes) and could mask genuine server startup failures by silently skipping
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
