reta commented on code in PR #3010:
URL: https://github.com/apache/cxf/pull/3010#discussion_r3024721574
##########
rt/features/metrics/src/main/java/org/apache/cxf/metrics/micrometer/MicrometerMetricsProvider.java:
##########
@@ -59,15 +59,33 @@ public MicrometerMetricsProvider(MeterRegistry registry,
/**
* {@inheritDoc}
*/
+
@Override
public MetricsContext createEndpointContext(Endpoint endpoint, boolean
asClient, String clientId) {
if (asClient) {
return null;
- } else {
- return new MicrometerServerMetricsContext(registry, tagsProvider,
timedAnnotationProvider, tagsCustomizers,
- micrometerMetricsProperties.getServerRequestsMetricName(),
- micrometerMetricsProperties.isAutoTimeRequests());
}
+ // For JAX-RS server endpoints, createResourceContext() is invoked per
Review Comment:
Thanks @ffang , I am wonderign why `createEndpointContext` is called for
JAX-RS endpoints? It looks like we have an issue at a bit higher layer, not
only with MicrometerMetricsProvider, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
