reta commented on code in PR #3091:
URL: https://github.com/apache/cxf/pull/3091#discussion_r3208503692


##########
core/src/main/java/org/apache/cxf/resource/URIResolver.java:
##########
@@ -56,6 +61,10 @@
  */
 public class URIResolver implements AutoCloseable {
     private static final Logger LOG = LogUtils.getLogger(URIResolver.class);
+    private static final String ALLOWED_URL_SCHEMES_PROPERTY =
+        "org.apache.cxf.resource.uriresolver.allowedSchemes";
+    private static final Set<String> DEFAULT_ALLOWED_URL_SCHEMES =
+        Collections.unmodifiableSet(new HashSet<>(Arrays.asList("file", 
"http", "https", "jar", "zip", "wsjar")));

Review Comment:
   We also probably need "local" for LocalTransport?
   
   ```suggestion
           Collections.unmodifiableSet(new HashSet<>(Arrays.asList("file", 
"http", "https", "jar", "zip", "wsjar", "local")));
   ```
   
   On the similar note, we added AbstractWrapperWSDLLocator::ALLOWED_SCHEMES 
recently for very similar purpose, do you think we could consolidate those or 
it does not make much sense? 
   
   Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to