reta commented on code in PR #3092:
URL: https://github.com/apache/cxf/pull/3092#discussion_r3208793725
##########
rt/rs/extensions/search/src/main/java/org/apache/cxf/jaxrs/ext/search/sql/SQLPrinterVisitor.java:
##########
@@ -32,6 +33,10 @@
public class SQLPrinterVisitor<T> extends
AbstractUntypedSearchConditionVisitor<T, String> {
+ private static final Pattern SQL_IDENTIFIER_PATTERN =
Pattern.compile("[A-Za-z_][A-Za-z0-9_]*");
Review Comment:
I am wondering if that is exhaustive / accurate? Fe Postgres let you use
quotes in name: `SELECT * FROM users AS "users_alias";`, may be we shouldn't
fail hard on those? Or there is a particular issue you run into?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
