reta commented on code in PR #3132:
URL: https://github.com/apache/cxf/pull/3132#discussion_r3280979421
##########
rt/rs/security/oauth-parent/oauth2/src/main/java/org/apache/cxf/rs/security/oauth2/grants/code/AuthorizationCodeGrantHandler.java:
##########
@@ -173,9 +173,9 @@ private boolean compareCodeVerifierWithChallenge(Client c,
String clientCodeVeri
return false;
}
}
- // Fall back to plain
+ // Fall back to digest
if (codeVerifierTransformer == null) {
- codeVerifierTransformer = new PlainCodeVerifier();
+ codeVerifierTransformer = new DigestCodeVerifier();
Review Comment:
Thanks @coheigea , two question:
- do you think we could make this default configurable? (fe on a class
level field, not a system property)
- seems like this is the only place where `PlainCodeVerifier` is used, if
we won't provide the option to supply default, it could be probably removed
WDYT? Thanks!
##########
rt/rs/security/oauth-parent/oauth2/src/main/java/org/apache/cxf/rs/security/oauth2/grants/code/AuthorizationCodeGrantHandler.java:
##########
@@ -173,9 +173,9 @@ private boolean compareCodeVerifierWithChallenge(Client c,
String clientCodeVeri
return false;
}
}
- // Fall back to plain
+ // Fall back to digest
if (codeVerifierTransformer == null) {
- codeVerifierTransformer = new PlainCodeVerifier();
+ codeVerifierTransformer = new DigestCodeVerifier();
Review Comment:
Thanks @coheigea , two questions please:
- do you think we could make this default configurable? (fe on a class
level field, not a system property)
- seems like this is the only place where `PlainCodeVerifier` is used, if
we won't provide the option to supply default, it could be probably removed
WDYT? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
