coheigea commented on code in PR #3137:
URL: https://github.com/apache/cxf/pull/3137#discussion_r3289484766


##########
rt/rs/security/jose-parent/jose/src/main/java/org/apache/cxf/rs/security/jose/jwt/JwtUtils.java:
##########
@@ -50,9 +50,14 @@ public static void validateJwtExpiry(JwtClaims claims, int 
clockOffset, boolean
             return;
         }
         Instant now = Instant.now();
-        Instant expires = Instant.ofEpochMilli(expiryTime * 1000L);
-        if (clockOffset != 0) {
-            expires = expires.plusSeconds(clockOffset);
+        Instant expires;
+        try {

Review Comment:
   @reta 1000L can overflow before creating the Instant, producing a wrong 
timestamp.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to