reta commented on code in PR #3241:
URL: https://github.com/apache/cxf/pull/3241#discussion_r3461090498
##########
rt/rs/security/sso/oidc/src/main/java/org/apache/cxf/rs/security/oidc/rp/OidcRpAuthenticationService.java:
##########
@@ -57,18 +57,42 @@ public Response completeAuthentication(@Context
OidcClientTokenContext oidcConte
URI redirectUri = null;
MultivaluedMap<String, String> state = oidcContext.getState();
String location = state != null ? state.getFirst("state") : null;
- if (location == null && defaultLocation != null) {
+ if (location != null) {
Review Comment:
> . if you'd rather the validation lived in the filter where the value is
first written, i'm happy to move it there.
Oh thanks for clarifying @dxbjavid , I think hardening filter would make
sense, also making sure the `state` is not colliding with the request state
(may be filtering here will help), thanks again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
