rnbwdsh commented on code in PR #3311: URL: https://github.com/apache/cxf/pull/3311#discussion_r3622040844
########## rt/frontend/jaxrs/src/test/java/org/apache/cxf/jaxrs/provider/EntityPartProviderTest.java: ########## @@ -0,0 +1,170 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.cxf.jaxrs.provider; + +import java.io.ByteArrayInputStream; +import java.io.InputStream; +import java.lang.annotation.Annotation; +import java.lang.reflect.Type; +import java.nio.charset.StandardCharsets; +import java.util.List; +import java.util.stream.IntStream; + +import jakarta.ws.rs.core.EntityPart; +import jakarta.ws.rs.core.MediaType; +import jakarta.ws.rs.ext.ContextResolver; +import jakarta.ws.rs.ext.ExceptionMapper; +import jakarta.ws.rs.ext.MessageBodyReader; +import jakarta.ws.rs.ext.MessageBodyWriter; +import jakarta.ws.rs.ext.Providers; +import org.apache.cxf.attachment.AttachmentDeserializer; +import org.apache.cxf.jaxrs.ext.MessageContextImpl; +import org.apache.cxf.jaxrs.impl.MetadataMap; +import org.apache.cxf.message.Exchange; +import org.apache.cxf.message.ExchangeImpl; +import org.apache.cxf.message.Message; +import org.apache.cxf.message.MessageImpl; + +import org.junit.Test; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertThrows; + +public class EntityPartProviderTest { + private final Providers providers = new Providers() { + @Override + public <T> MessageBodyReader<T> getMessageBodyReader(Class<T> type, + Type genericType, Annotation[] annotations, MediaType mediaType) { + return new BinaryDataProvider<>(); + } + + @Override + public <T> MessageBodyWriter<T> getMessageBodyWriter(Class<T> type, + Type genericType, Annotation[] annotations, MediaType mediaType) { + throw new UnsupportedOperationException(); + } + + @Override + public <T extends Throwable> ExceptionMapper<T> getExceptionMapper(Class<T> type) { + throw new UnsupportedOperationException(); + } + + @Override + public <T> ContextResolver<T> getContextResolver(Class<T> contextType, MediaType mediaType) { + throw new UnsupportedOperationException(); + } + + }; + + @SuppressWarnings("unchecked") + @Test + public void testChangingMaxAttachmentCount() throws Exception { + final Exchange exchange = new ExchangeImpl(); + final EntityPartProvider p = new EntityPartProvider(); + + StringBuilder sb = new StringBuilder(1000); + sb.append("SomeHeader: foo\n") + .append("------=_Part_34950_1098328613.1263781527359\n") + .append("Content-Type: text/xml; charset=UTF-8\n") + .append("Content-Transfer-Encoding: binary\n") + .append("Content-Id: <318731183421.1263781527359.IBM.WEBSERVICES@auhpap02>\n") + .append('\n') + .append("<envelope/>\n"); + + // Add many attachments + IntStream.range(0, 40).forEach(i -> { + sb.append("------=_Part_34950_1098328613.1263781527359\n") Review Comment: Generally, the standard suggests CRLF as terminators, and optionally allows `\r` here, but this tests would break if cxf would ever implement strict parsing. I think the more leniant parsing is an active choice, I still think the tests should produce RFC complaint inputs, otherwise fixing this in the future will break things. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
