reta commented on code in PR #3348:
URL: https://github.com/apache/cxf/pull/3348#discussion_r3674407445
##########
rt/rs/security/oauth-parent/oauth2/src/main/java/org/apache/cxf/rs/security/oauth2/provider/AbstractOAuthDataProvider.java:
##########
@@ -271,6 +271,17 @@ public void revokeToken(Client client, String tokenKey,
String tokenTypeHint) th
@Override
public void revokeToken(Client client, UserSubject callerSubject, String
tokenKey, String tokenTypeHint)
throws OAuthServiceException {
+ if (!recycleRefreshTokens) {
Review Comment:
Nit, may be a bit better to read the flow, wdyt?
```suggestion
if (!recycleRefreshTokens) {
synchronized (refreshTokenLock) {
doRevokeToken(client, callerSubject, tokenKey,
tokenTypeHint);
}
} else {
doRevokeToken(client, callerSubject, tokenKey, tokenTypeHint);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
