reta commented on code in PR #3358:
URL: https://github.com/apache/cxf/pull/3358#discussion_r3743875989
##########
rt/rs/security/oauth-parent/oauth2/src/main/java/org/apache/cxf/rs/security/oauth2/grants/code/JPACMTCodeDataProvider.java:
##########
@@ -129,12 +132,29 @@ protected RefreshToken
updateExistingRefreshToken(RefreshToken rt, ServerAccessT
return super.updateExistingRefreshToken(rt, at);
}
+ @Override
+ protected ServerAuthorizationCodeGrant removeCodeGrant(String code,
EntityManager em,
Review Comment:
I believe the check + removal should happen in the same transaction scope
(`executeInTransaction`), fe doRemoveClient / removeClientCodeGrants are good
references
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
