karlvr commented on PR #3133: URL: https://github.com/apache/cxf/pull/3133#issuecomment-5274108570
@coheigea Do you remember the reason for this change or do you know the reason for synchronisation in this code path at all? We had already worked around the synchronisation elsewhere for non-recycled refresh tokens and now we've had to work around this one (slightly harder due to the private method it calls). It doesn't _appear_ to us that there's any need to synchronise, there's no shared state? only the objects passed in are mutated. This style of global synchronisation block causes large problems for us in this highly concurrent point in the stack. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
