reta commented on code in PR #3504:
URL: https://github.com/apache/cxf/pull/3504#discussion_r4104261651
##########
rt/rs/security/xml/src/main/java/org/apache/cxf/rs/security/saml/SamlEnvelopedInHandler.java:
##########
@@ -68,6 +70,12 @@ public void filter(ContainerRequestContext context) {
XMLStreamReader reader = message.getContent(XMLStreamReader.class);
if (reader instanceof W3CDOMStreamReader) {
doc = ((W3CDOMStreamReader)reader).getDocument();
Review Comment:
Just a nit - we do casts several times, may be having it once is better:
```suggestion
W3CDOMStreamReader w3cReader = (W3CDOMStreamReader)reader;
doc = w3cReader.getDocument();
...
Node node = w3cReader.getCurrentNode();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
