markusheiden commented on PR #3565: URL: https://github.com/apache/cxf/pull/3565#issuecomment-6099020084
Thanks @reta, makes sense. I've reverted the guards in `handleResponse` and instead fixed the call sites that don't follow the contract (`WebClient`'s `ClientAsyncResponseInterceptor` and the fault observer wrapper in `ClientImpl`), with a system test in `JAXRSAsyncClientTest`. I kept the guards on the failure paths in the callbacks (`handleException`, `cancel`, and the interrupted `get`): if the user's handler throws there, the caller has no way left to complete the future, since it belongs to the callback. In the original BingAds case, the `AsyncHandler` throws again when it's invoked from `handleException`, so the future still hung. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
