reta commented on code in PR #3597:
URL: https://github.com/apache/cxf/pull/3597#discussion_r4313238017
##########
core/src/main/java/org/apache/cxf/resource/URIResolver.java:
##########
@@ -65,6 +65,8 @@ public class URIResolver implements AutoCloseable {
private static final Logger LOG = LogUtils.getLogger(URIResolver.class);
private static final String ALLOWED_URL_SCHEMES_PROPERTY =
"org.apache.cxf.resource.uriresolver.allowedSchemes";
+ private static final String DENIED_URL_SCHEMES_PROPERTY =
Review Comment:
Thanks @RusJaI
> Keep this PR limited to the EndpointReferenceUtils change, preventing
remote schema fetching in SchemaLSResourceResolver without introducing
configuration changes. I'll remove deniedSchemes and the URIResolver changes.
This is disruptive change I think since
`EndpointReferenceUtils::SchemaLSResourceResolver` clearly documents that
remote schemas will be handled:
```
* We want to load the schemas, including references to external
schemas, into a SchemaFactory
* to validate. There seem to be bugs in resolving inter-schema
references in Xerces, so even when we are
* handing the factory all the schemas, interrelated with
<import> elements, we need
* to also hand over extra copies (!) as character images when
requested.
```
> One clarification that affects the approach: in the released versions
(3.6.12, 4.1.6+, 4.2.1+), allowedSchemes is additive. getAllowedSchemes()
starts with DEFAULT_ALLOWED_URL_SCHEMES and adds the configured schemes, so it
cannot currently exclude http, https, or file.
@coheigea regarding additive part, should we consider the full override
instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
