dxbjavid commented on code in PR #3603:
URL: https://github.com/apache/cxf/pull/3603#discussion_r4322714543
##########
rt/rs/security/oauth-parent/oauth2/src/main/java/org/apache/cxf/rs/security/oauth2/filters/OAuthRequestFilter.java:
##########
@@ -236,6 +238,17 @@ protected boolean checkRequestURI(HttpServletRequest
request, List<String> uris,
}
return foundValidScope;
}
+
+ private boolean hasAllRequiredScopes(List<OAuthPermission>
matchingPermissions) {
Review Comment:
Fair point, without a getter an override of either method had nothing to
match against. I've added a protected getRequiredScopes(), which I think suits
checkScopeProperty overrides better than threading the list through as a
parameter. The comment is now a short Javadoc covering what the method receives
and noting that loose checkScopeProperty overrides should override this one
too, and the note about duplicates is kept.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
