ffang commented on PR #3620: URL: https://github.com/apache/cxf/pull/3620#issuecomment-6426088762
Hi @reta, @coheigea, Heads-up: I've rewritten this PR and force-pushed it as a single commit, cb45590, rebased on the current `main`. The earlier commits (370c501, 867621c) are gone; cb45590 replaces the previous approach entirely rather than building on it. Following @reta's suggestion, the logging feature no longer knows about the Servlet API: - A new `Message.RESPONSE_HEADERS` key in core holds a read-only, lazily evaluated view of the effective outgoing response headers. - The HTTP transport (`AbstractHTTPDestination`) populates it and owns all the servlet access and merge rules, reusing the same formatting as `Headers.copyToResponse`. - For outgoing responses and faults, logging reads that view, falling back to `PROTOCOL_HEADERS` when it isn't set. That keeps it transport-neutral, with no Servlet API dependency or transport constants. - Servlet headers are not added to `PROTOCOL_HEADERS`, so header precedence (including `Content-Type`) is unchanged. @coheigea's earlier points (failure fallback, constants, consistent multi-value formatting, case-insensitive masking) are carried over into the new design. Since the history was rewritten, the earlier review threads may show as outdated; it's probably easiest to review cb45590 as a whole. Thanks! Freeman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
