vp340 commented on PR #3660: URL: https://github.com/apache/cxf/pull/3660#issuecomment-6589649657
Hi @ffang , Good catch thanks! . Sorry my fault, I apologize. I had run only http transport tests cause my pc is slow as a turtle and I have some conflict to generate all the resources . Now I apply the change as U describe and add the http2 GET test that without your fix fail also with: > JettyClientServerHttp2Test.testGetWithChunkingHttp2:79 ยป Processing java.io.IOException: IOException invoking https://localhost:39501/http2/web/bookstore/pluto: java.io.UncheckedIOException: java.io.IOException: Pipe not connected Now it runs ok along with other tests :) ! Only one doubt : > One problem though: when contentLen == 0 (GET/DELETE) Here U said also DELETE method, but I see: > if (KNOWN_HTTP_VERBS_WITH_NO_CONTENT.contains(httpRequestMethod) || PropertyUtils.isTrue(outMessage.get(Headers.EMPTY_REQUEST_PROPERTY))) { contentLen = 0; } protected static final Set<String> KNOWN_HTTP_VERBS_WITH_NO_CONTENT = new HashSet<>(Arrays.asList(new String[]{"GET", "HEAD", "OPTIONS", "TRACE"})); So either we are sure that DELETE meets 'PropertyUtils.isTrue(outMessage.get(Headers.EMPTY_REQUEST_PROPERTY))' or we need to be sure that who use DELETE with nobody "doesn't subscribe"/ "set manually the contentLen to 0" . Let me know what U think... and if the new commits are ok for U. Thanks again, Valentino Porta -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
