reta commented on code in PR #3674:
URL: https://github.com/apache/cxf/pull/3674#discussion_r4460127629
##########
rt/transports/http-hc5/src/main/java/org/apache/cxf/transport/http/asyncclient/hc5/SharedInputBuffer.java:
##########
@@ -97,6 +97,9 @@ public int consumeContent(final ByteBuffer buffer, boolean
last) throws IOExcept
}
if (!buffer().hasRemaining() && !this.endOfStream) {
+ // Wake up a reader waiting for data first: only the reader
signals suspendInput,
+ // once it has drained the buffer
+ this.condition.signalAll();
Review Comment:
@ffang I think we need to think about the consequence of the change: so we
do call `this.condition.signalAll();` here now and also right after the `if`
block. Do we need to do this twice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
