ffang commented on PR #3679: URL: https://github.com/apache/cxf/pull/3679#issuecomment-6633474933
Thanks @coheigea, LGTM. Matching a method only to the generic methods it actually overrides, as `OAuthScopesFilter` and `ClaimsAuthorizingInterceptor` already do, fixes a real gap: an implementation's class-level `@RolesAllowed` no longer hides the method-level `@RolesAllowed` of the generic interface method. Core tests pass with `-Psourcecheck`, and all six new tests fail against the current interceptor. Just one Nit: getGenericallyOverriddenMethods rebuilds the type-argument map of the whole class hierarchy for every method, and findRoles calls it for every class in the hierarchy. It only runs at setup, so it doesn't matter much, though the map could be computed once per class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
