ffang commented on PR #3687:
URL: https://github.com/apache/cxf/pull/3687#issuecomment-6687506614

   > > Thanks @coheigea , failing closed is the right call. I checked that an 
empty rule really does deny every user, anonymous ones included.
   > 
   > @ffang I think this change is not about empty rules but a security related 
annotation without `value` attribute, fe:
   > 
   > ```java
   > @interface MySecurityAnnotation {
   > }
   > ```
   > 
   > The empty value (roles) is a bit different case, thank you
   
   @reta agreed, sorry for the confusion. By "empty rule" I meant the fallback 
in `getRoles`: when the roles can't be read, it returns an empty list, and 
`authorize` treats that as "deny everyone" rather than "unprotected". 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to