This all seems reasonable to me. One thing I noticed though is that there is no ability to accept the pull request and merge it in via the github interface as described in our workflow [1]. I think this functionality is enabled by enabling Apache GitBox. I'll open an infra ticket to enable GitBox for Daffodil, but I think we all also need to link our Apache and GitHub accounts via:
https://gitbox.apache.org/setup/ - Steve [1] https://cwiki.apache.org/confluence/display/DAFFODIL/Code+Contributor+Workflow On 10/31/2017 11:23 AM, mbeckerle wrote: > Github user mbeckerle commented on a diff in the pull request: > > https://github.com/apache/incubator-daffodil/pull/1#discussion_r148030522 > > --- Diff: > daffodil-core/src/main/scala/edu/illinois/ncsa/daffodil/dpath/Expression.scala > --- > @@ -294,8 +294,8 @@ case class ComparisonExpression(op: String, adds: > List[Expression]) > case ("=", _) => subsetError("Unsupported operation '%s'. Use 'eq' > instead.", op) > case ("!=", _) => subsetError("Unsupported operation '%s'. Use > 'ne' instead.", op) > > - case("eq", HexBinary) => EQ_CompareByteArray > - case("ne", HexBinary) => NE_CompareByteArray > + case ("eq", HexBinary) => EQ_CompareByteArray > + case ("ne", HexBinary) => NE_CompareByteArray > --- End diff -- > > Thank you for that useful comment. (Just a test of comments and replies > while I figure out this code-review system.) > > > --- >
