Github user mbeckerle commented on a diff in the pull request:

    https://github.com/apache/incubator-daffodil/pull/5#discussion_r149845076
  
    --- Diff: 
daffodil-lib/src/main/scala/edu/illinois/ncsa/daffodil/oolag/OOLAG.scala ---
    @@ -131,18 +131,30 @@ object OOLAG extends Logging {
        * already. This insures that the value exists for 'foo', or any 
errors/warnings
        * to be determined by its calculation have been recorded.
        */
    -  abstract class OOLAGHost private (oolagContextArg: OOLAGHost, nArgs: 
Args)
    +  abstract class OOLAGHostImpl private (
    +    final override val oolagContextArg: OOLAGHost,
    --- End diff --
    
    Rename. Shouldn't be named with "Arg" suffix if it's public.


---

Reply via email to