Github user stevedlawrence commented on a diff in the pull request:

    https://github.com/apache/incubator-daffodil/pull/5#discussion_r150594216
  
    --- Diff: 
daffodil-core/src/main/scala/edu/illinois/ncsa/daffodil/dsom/ChoiceGroup.scala 
---
    @@ -257,3 +275,13 @@ final class Choice(xmlArg: Node, parent: 
SchemaComponent, position: Int)
           optIgnoreCase)
       }
     }
    +
    +final class Choice(xmlArg: Node, parent: SchemaComponent, position: Int)
    +  extends ChoiceBase(xmlArg, parent, position)
    +  with ChoiceLikeMixin
    --- End diff --
    
    If ChoiceBase should mixin ChoiceLikeMixin, this isn't necessary. But maybe 
the above is wrong?


---

Reply via email to