Github user stevedlawrence commented on a diff in the pull request:

    https://github.com/apache/incubator-daffodil/pull/5#discussion_r150870368
  
    --- Diff: 
daffodil-runtime1/src/main/scala/edu/illinois/ncsa/daffodil/infoset/InfosetImpl.scala
 ---
    @@ -213,7 +213,7 @@ case class 
InfosetValueLengthUnknownException(lengthState: LengthState, override
     final class FakeDINode extends DISimple(null) {
       private def die = throw new InfosetNoInfosetException(Nope)
     
    -  override def parent = die
    +  override val parent = die
    --- End diff --
    
    Maybe FakeDINode is just never allocated? Looks like it's only allocated 
when currentNode is called in DStateForConstantFolding. Maybe we just don't 
have a test for that?


---

Reply via email to