GitHub user mbeckerle opened a pull request:
https://github.com/apache/incubator-daffodil/pull/7
Eliminate spurious SDE when using lengthKind pattern on all-text file.
The isScannable computation is incorrect. For entirely textual formats
in one encoding it still comes up with isScannable false.
This causes a SDE if you are using lengthKind pattern. The SDE says the
data must be scannable in order to use lengthKind pattern.
This applies the patch 22b7bc7238a5434570ebd088357c9f25bf09a8c9 from
support/v2.0.x branch to the master branch.
There has been enough change to master (files moved, removed, etc.), and
some functional change affecting test behavior, and this is such a small
change set, that applying it by just re-editing the files was easiest;
hence, I did not do a rebase and then resolve the conflicts, nor use any
git cherry-pick operation.
DAFFODIL-1864
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbeckerle/incubator-daffodil
daffodil-1864-pattern-sde
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-daffodil/pull/7.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7
----
commit d281332df165299d51af176aab457615f8c622a6
Author: mbeckerle <[email protected]>
Date: 2017-11-29T12:32:16Z
Eliminate spurious SDE when using lengthKind pattern on all-text file.
The isScannable computation is incorrect. For entirely textual formats
in one encoding it still comes up with isScannable false.
This causes a SDE if you are using lengthKind pattern. The SDE says the
data must be scannable in order to use lengthKind pattern.
This applies the patch 22b7bc7238a5434570ebd088357c9f25bf09a8c9 from
support/v2.0.x branch to the master branch.
There has been enough change to master (files moved, removed, etc.), and
some functional change affecting test behavior, and this is such a small
change set, that applying it by just re-editing the files was easiest;
hence, I did not do a rebase and then resolve the conflicts, nor use any
git cherry-pick operation.
DAFFODIL-1864
----
---
