stevedlawrence commented on a change in pull request #16: Implemented packed binary formats URL: https://github.com/apache/incubator-daffodil/pull/16#discussion_r155253957
########## File path: build.sbt ########## @@ -39,7 +39,8 @@ libraryDependencies in ThisBuild := Seq( "org.fusesource.jansi" % "jansi" % "1.14", "org.rogach" %% "scallop" % "0.9.5", // new version avail. 2.0.5 requires code changes "commons-io" % "commons-io" % "2.5", - "org.scalacheck" %% "scalacheck" % "1.13.4" % "test" + "org.scalacheck" %% "scalacheck" % "1.13.4" % "test", + "net.sf.jt400" % "jt400" % "8.5" Review comment: Make sure to mention the new dependency and its license in the commit messages, as well as the purpose for the dependency. If there are ever any licensing issues. Adding new dependencies can conflict with the Apachev2 license so it's good to point those out. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
