mbeckerle commented on a change in pull request #16: Implemented packed binary
formats
URL: https://github.com/apache/incubator-daffodil/pull/16#discussion_r155290790
##########
File path:
daffodil-core/src/main/scala/edu/illinois/ncsa/daffodil/grammar/ElementBaseGrammarMixin.scala
##########
@@ -480,7 +504,8 @@ trait ElementBaseGrammarMixin
case LengthKind.Implicit => implicitBinaryLengthInBits
Review comment:
Can you please insert two Assert.usage tests at the top of this lazy val.
Assert.usage(impliedRepresentation eq Representation.Binary)
Assert.usage(primType.isInstanceOf[NodeInfo.Numeric.Kind])
If this breaks things I'd like to know, if not I'd like to start being
explicit like this about the preconditions of these members.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
