mbeckerle commented on a change in pull request #16: Implemented packed binary
formats
URL: https://github.com/apache/incubator-daffodil/pull/16#discussion_r155312057
##########
File path:
daffodil-test/src/test/scala-new/edu/illinois/ncsa/daffodil/section13/packed/TestPacked.scala
##########
@@ -54,4 +54,18 @@ class TestPacked {
// @Test def testHexCharset03(): Unit = { runner.runOneTest("hexCharset03")
} // textNumberPattern V symbol
@Test def testHexCharset04(): Unit = { runner.runOneTest("hexCharset04") }
+ @Test def testPackedCharset01(): Unit = {
runner.runOneTest("packedCharset01") }
+ @Test def testPackedCharset02(): Unit = {
runner.runOneTest("packedCharset02") }
+ @Test def testPackedCharset03(): Unit = {
runner.runOneTest("packedCharset03") }
+ //@Test def testPackedCharset04(): Unit = {
runner.runOneTest("packedCharset04") } // need packed calendar
+
+ @Test def testBCDCharset01(): Unit = { runner.runOneTest("bcdCharset01") }
+ @Test def testBCDCharset02(): Unit = { runner.runOneTest("bcdCharset02") }
+ @Test def testBCDCharset03(): Unit = { runner.runOneTest("bcdCharset03") }
+ //@Test def testBCDCharset04(): Unit = { runner.runOneTest("bcdCharset04") }
// need bcd calendar
+
+ @Test def testIBM4690Charset01(): Unit = {
runner.runOneTest("IBM4690Charset01") }
+ @Test def testIBM4690Charset02(): Unit = {
runner.runOneTest("IBM4690Charset02") }
+ @Test def testIBM4690Charset03(): Unit = {
runner.runOneTest("IBM4690Charset03") }
+ //@Test def testIBM4690Charset04(): Unit = {
runner.runOneTest("IBM4690Charset04") } // need bcd calendar
Review comment:
I'd like to see unit tests in daffodil-lib-unitttest for the
DecimalUtils.scala library. Basically because it can be tested there. These
tests can then be insuring that the prims and parsers are invoking the right
decimal util methods based on the properties provided, and detects the right
errors, and not so much on whether the underlying library does the basics
right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
