mbeckerle commented on a change in pull request #12: Revised daffodil-io module
to require passing in a FormatInfo object.
URL: https://github.com/apache/incubator-daffodil/pull/12#discussion_r157905301
##########
File path:
daffodil-io/src/main/scala/edu/illinois/ncsa/daffodil/io/DirectOrBufferedDataOutputStream.scala
##########
@@ -95,6 +101,18 @@ final class DirectOrBufferedDataOutputStream private[io]
(var splitFrom: DirectO
extends DataOutputStreamImplMixin {
type ThisType = DirectOrBufferedDataOutputStream
+ override def putULong(unsignedLong: ULong, bitLengthFrom1To64: Int, finfo:
FormatInfo): Boolean = {
+ val res = putLongChecked(unsignedLong.longValue, bitLengthFrom1To64, finfo)
+ setPriorBitOrder(finfo.bitOrder)
Review comment:
Might not be needed anymore. Done centrally now in unparser and in the
ElementUnparser combinator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
