stevedlawrence commented on a change in pull request #12: Revised daffodil-io module to require passing in a FormatInfo object. URL: https://github.com/apache/incubator-daffodil/pull/12#discussion_r158020356
########## File path: daffodil-core/src/main/scala/edu/illinois/ncsa/daffodil/grammar/primitives/PrimitivesBinaryNumber.scala ########## @@ -50,17 +50,13 @@ import edu.illinois.ncsa.daffodil.processors.unparsers.BinaryFloatUnparser class BinaryIntegerRuntimeLength(val e: ElementBase, signed: Boolean) extends Terminal(e, true) { Review comment: One of the commits in my Apache licensing changeset is to fix all the CRLF issues, so I wouldn't worry about it in this commit if it doesn't cause any problems. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services