stevedlawrence commented on a change in pull request #24: Make TDML Runner not
strip all attributes
URL: https://github.com/apache/incubator-daffodil/pull/24#discussion_r159973436
##########
File path:
daffodil-tdml/src/main/scala/edu/illinois/ncsa/daffodil/tdml/TDMLRunner.scala
##########
@@ -1770,33 +1769,33 @@ case class DFDLInfoset(di: Node, parent: Infoset) {
}
}
- val rawContents = {
+ val contents = {
Assert.usage(infosetNodeSeq.size == 1, "dfdlInfoset element must contain a
single root element")
val c = infosetNodeSeq(0)
c
}
- val Seq(contents) = {
- val c = rawContents
- val expected = c // Utility.trim(c) // must be exactly one root element in
here.
- val expectedNoAttrs = try {
- XMLUtils.removeAttributes(expected)
- } catch {
- case e: Exception => throw new TDMLException(e)
- }
- //
- // Let's validate the expected content against the schema
- // Just to be sure they don't drift.
- //
- // val ptc = parent.parent
- // val schemaNode = ptc.findModel(ptc.model)
- //
- // This is causing trouble, with the stripped attributes, etc.
- // TODO: Fix so we can validate these expected results against
- // the DFDL schema used as a XSD for the expected infoset XML.
- //
- expectedNoAttrs
- }
+ // val Seq(contents) = {
+ // val c = rawContents
+ // val expected = c // Utility.trim(c) // must be exactly one root
element in here.
+ // val expectedNoAttrs = try {
+ // XMLUtils.removeAttributes(expected)
+ // } catch {
+ // case e: Exception => throw new TDMLException(e)
+ // }
+ // //
+ // // Let's validate the expected content against the schema
+ // // Just to be sure they don't drift.
+ // //
+ // // val ptc = parent.parent
+ // // val schemaNode = ptc.findModel(ptc.model)
+ // //
+ // // This is causing trouble, with the stripped attributes, etc.
+ // // TODO: Fix so we can validate these expected results against
+ // // the DFDL schema used as a XSD for the expected infoset XML.
+ // //
+ // expectedNoAttrs
+ // }
Review comment:
Remove comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
