Done. See PR 26 https://github.com/apache/incubator-daffodil/pull/26
________________________________ From: Steve Lawrence <[email protected]> Sent: Tuesday, January 16, 2018 7:13:57 AM To: [email protected]; Mike Beckerle Subject: Re: Code review request I think a better way would be to just create a new branch with a different name and push it as a new PR to the apache/incubator-daffodil repo. Since it has a different name github won't muck with the existing pull request, and any comments/+1's will get mirrored to the dev list. You can close the old PR and we can reference it if necessary. On 01/10/2018 08:59 PM, Mike Beckerle wrote: > I would very much like to get the changes described by these two pull > requests integrated before the big apache package and file change. > > > https://github.com/apache/incubator-daffodil/pull/23 > > > https://github.com/mbeckerle/incubator-daffodil/pull/4 > > > These two PRs are effectively part of the same change set which will get > squashed before applying it. > > > When you rebase the commits in a PR review, onto master, and push, you have > to force push and so the prior comment history all gets clobbered. > > > But I wanted the changes needed to rebase onto master and get things working > to get reviewed as well. > > > So I created this separate PR which is on my mbeckerle mirror repository, but > it contains only the deltas from where PR 23 left off, that are needed to > rebase onto master. > > > Perhaps there is a better way to do this, but this is what I came up with for > now. > > > > >
