stevedlawrence commented on a change in pull request #16: Implemented packed
binary formats
URL: https://github.com/apache/incubator-daffodil/pull/16#discussion_r163252022
##########
File path:
daffodil-runtime1/src/main/scala/edu/illinois/ncsa/daffodil/processors/parsers/PackedBinaryTraits.scala
##########
@@ -101,7 +100,7 @@ abstract class PackedBinaryIntegerBaseParser(
val int = toBigInteger(dis.getByteArray(nBits, start))
start.simpleElement.overwriteDataValue(int)
Review comment:
It looks like the ``signed`` variable in PackedBinaryIntegerBaseParser is
never used. I think you just need to throw a PE if signed is false but the
``val int`` result of toBigInteger is negative? Also, while you're in this
section, it doesn't look like the ``signed`` variable needs a default value.
All uses of this base class pass in the signed variable.
+1 with those two minor issues fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
