mbeckerle commented on a change in pull request #34: Daffodil 1884 bit order
URL: https://github.com/apache/incubator-daffodil/pull/34#discussion_r166789367
##########
File path:
daffodil-runtime1/src/main/scala/edu/illinois/ncsa/daffodil/processors/unparsers/Unparser.scala
##########
@@ -64,6 +64,10 @@ sealed trait Unparser
if (ustate.dataProc.isDefined) ustate.dataProc.get.before(ustate, this)
try {
unparse(ustate)
+ this.context match {
+ case trd: TermRuntimeData =>
ustate.dataOutputStream.setPriorBitOrder(ustate.bitOrder)
+ case _ => //ok
+ }
Review comment:
Interesting that I can simplify this and just call ustate.bitOrder here. The
setPriorBitOrder is a red-herring.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
